[KYUUBI #4152][FOLLOWUP] LDAP configurations should be server-only#4383
Closed
pan3793 wants to merge 1 commit intoapache:masterfrom
Closed
[KYUUBI #4152][FOLLOWUP] LDAP configurations should be server-only#4383pan3793 wants to merge 1 commit intoapache:masterfrom
pan3793 wants to merge 1 commit intoapache:masterfrom
Conversation
pan3793
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4383 +/- ##
============================================
- Coverage 53.69% 53.68% -0.01%
Complexity 13 13
============================================
Files 563 563
Lines 30877 30877
Branches 4164 4164
============================================
- Hits 16579 16577 -2
- Misses 12743 12749 +6
+ Partials 1555 1551 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pan3793
added a commit
that referenced
this pull request
Feb 20, 2023
### _Why are the changes needed?_ Filter out the LDAP configurations to suppress potential security issues. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4383 from pan3793/auth-conf. Closes #4152 032245f [Cheng Pan] [KYUUBI #4152] LDAP configurations should be server-only Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit ae374c1) Signed-off-by: Cheng Pan <chengpan@apache.org>
Member
Author
|
Thanks, merged to master/1.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Filter out the LDAP configurations to suppress potential security issues.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request