[KYUUBI #4412][FOLLOWUP] Fallback to new engine session handle for UT#4414
Closed
turboFei wants to merge 4 commits intoapache:masterfrom
Closed
[KYUUBI #4412][FOLLOWUP] Fallback to new engine session handle for UT#4414turboFei wants to merge 4 commits intoapache:masterfrom
turboFei wants to merge 4 commits intoapache:masterfrom
Conversation
turboFei
force-pushed
the
get_or_else
branch
from
4a904a1 to
967ae41
Compare
turboFei
changed the title
turboFei
commented
Feb 25, 2023
kyuubi-server/src/main/scala/org/apache/kyuubi/client/KyuubiSyncThriftClient.scala
Show resolved
Hide resolved
turboFei
commented
Feb 25, 2023
kyuubi-server/src/test/scala/org/apache/kyuubi/operation/KyuubiOperationPerUserSuite.scala
Show resolved
Hide resolved
turboFei
force-pushed
the
get_or_else
branch
from
e4444b5 to
f8583ec
Compare
Codecov Report
@@ Coverage Diff @@
## master #4414 +/- ##
============================================
- Coverage 53.81% 53.76% -0.05%
Complexity 13 13
============================================
Files 564 564
Lines 30949 30955 +6
Branches 4170 4170
============================================
- Hits 16656 16644 -12
- Misses 12737 12753 +16
- Partials 1556 1558 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
Author
|
@pan3793 fixed |
Member
Author
|
merging to master, because it is a minor pr and block the main branch. |
turboFei
added a commit
that referenced
this pull request
Feb 25, 2023
### _Why are the changes needed?_ ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4414 from turboFei/get_or_else. Closes #4412 e7d45ef [fwang12] refactor f8583ec [fwang12] use different handle for alive probe 33a776c [fwang12] launch sync 967ae41 [fwang12] [KYUUBI #4412][FOLLOWUP] Fallback to new engine session handle for UT Authored-by: fwang12 <fwang12@ebay.com> Signed-off-by: fwang12 <fwang12@ebay.com> (cherry picked from commit 787f86c) Signed-off-by: fwang12 <fwang12@ebay.com>
Member
|
Thanks, late LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request