Log error when handling session exception #4787
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
force-pushed
the
log_session_error
branch
from
20dbeb9 to
aaa5da9
Compare
turboFei
changed the title
pan3793
reviewed
May 5, 2023
| f | ||
| } catch { | ||
| case t: Throwable => | ||
| error(s"Handling $user session[$handle] exception:", t) |
Member
There was a problem hiding this comment.
for exceptions that will be re-thrown, seems no need to print stacktrace here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Log the session exception when handling it, otherwise, we can only lookup it from events.
For example, if the exception thrown by
engine.getOrCreate(discoveryClient, extraEngineLog), now there is no log for that.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request