[KYUUBI #4950][FOLLOWUP] Misc improvement for usage of SQLite#4953
Closed
pan3793 wants to merge 1 commit intoapache:masterfrom
Closed
[KYUUBI #4950][FOLLOWUP] Misc improvement for usage of SQLite#4953pan3793 wants to merge 1 commit intoapache:masterfrom
pan3793 wants to merge 1 commit intoapache:masterfrom
Conversation
github-actions
bot
added
kind:build
kind:documentation
bowenliang123
approved these changes
Jun 13, 2023
Codecov Report
@@ Coverage Diff @@
## master #4953 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 563 563
Lines 30949 30954 +5
Branches 4033 4033
======================================
- Misses 30949 30954 +5
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cfmcgrady
reviewed
Jun 13, 2023
| @@ -26,10 +26,10 @@ CREATE TABLE IF NOT EXISTS metadata( | |||
| peer_instance_closed boolean default '0' -- closed by peer kyuubi instance | |||
| ); | |||
Contributor
There was a problem hiding this comment.
curious, as JDBCMetadataStore#getLatestSchemaUrl always return the latest version of metadata store schema, and the SQLite support has been available since v1.8.0, do we still need to provide metadata-store-schema-1.6.0.sqlite.sql?
Member
Author
There was a problem hiding this comment.
You are right, we don't need that. Let's fix it and remove it later, to provide a valid example for future changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
IF NOT EXISTSonCREATE INDEXstatement.kyuubi.metadata.store.jdbc.urlconfiguration description.build/mvn cleanHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request