[KYUUBI #5177] Use Scala binary version placeholder in Maven module's artifactId suffix#5175
Closed
bowenliang123 wants to merge 1 commit intoapache:masterfrom
Closed
[KYUUBI #5177] Use Scala binary version placeholder in Maven module's artifactId suffix#5175bowenliang123 wants to merge 1 commit intoapache:masterfrom
bowenliang123 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
Postpone this change to introduction of scala 2.13 profile. |
Codecov Report
@@ Coverage Diff @@
## master #5175 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 566 566
Lines 31699 31699
Branches 4134 4134
======================================
Misses 31699 31699 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pan3793
approved these changes
Aug 20, 2023
Member
|
Thanks, merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
artifactIdto placeholderscala.binary.versionwhich is defined in project parent pom as 2.12How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?
No.