Skip to content

[KYUUBI #5177] Use Scala binary version placeholder in Maven module's artifactId suffix#5175

Closed
bowenliang123 wants to merge 1 commit intoapache:masterfrom
bowenliang123:artifactId-scala
Closed

[KYUUBI #5177] Use Scala binary version placeholder in Maven module's artifactId suffix#5175
bowenliang123 wants to merge 1 commit intoapache:masterfrom
bowenliang123:artifactId-scala

Conversation

@bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Aug 17, 2023

Why are the changes needed?

  • Change hardcoded Scala's version 2.12 in Maven module's artifactId to placeholder scala.binary.version which is defined in project parent pom as 2.12
  • Preparation for Scala 2.13/3.x support in the future
  • No impact on using or building Maven modules
  • Some ignorable warning messages for unstable artifactId will be thrown by Maven.
Warning:  Some problems were encountered while building the effective model for org.apache.kyuubi:kyuubi-server_2.12:jar:1.8.0-SNAPSHOT
Warning:  'artifactId' contains an expression but should be a constant

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

Was this patch authored or co-authored using generative AI tooling?

No.

@bowenliang123 bowenliang123 changed the title Use Scala binary version in maven module's artifactId Use Scala binary version placeholder in maven module's artifactId Aug 17, 2023
@bowenliang123 bowenliang123 changed the title Use Scala binary version placeholder in maven module's artifactId Use Scala binary version placeholder in maven module's artifactId suffix Aug 17, 2023
@bowenliang123 bowenliang123 requested a review from pan3793 August 17, 2023 03:20
@bowenliang123 bowenliang123 changed the title Use Scala binary version placeholder in maven module's artifactId suffix Use Scala binary version placeholder in Maven module's artifactId suffix Aug 17, 2023
@bowenliang123 bowenliang123 changed the title Use Scala binary version placeholder in Maven module's artifactId suffix [KYUUBI #5177] Use Scala binary version placeholder in Maven module's artifactId suffix Aug 17, 2023
@bowenliang123
Copy link
Contributor Author

Postpone this change to introduction of scala 2.13 profile.

@pan3793 pan3793 reopened this Aug 20, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #5175 (2eba29c) into master (f05aefb) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5175   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         566     566           
  Lines       31699   31699           
  Branches     4134    4134           
======================================
  Misses      31699   31699           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pan3793 pan3793 added this to the v1.8.0 milestone Aug 20, 2023
@pan3793 pan3793 closed this in 4213e20 Aug 20, 2023
@pan3793
Copy link
Member

pan3793 commented Aug 20, 2023

Thanks, merged to master

@bowenliang123 bowenliang123 deleted the artifactId-scala branch August 29, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants