[KYUUBI #5210] Cancel operation will cause the log file node to leak #5211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5211 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 590 590
Lines 33357 33357
Branches 4407 4407
======================================
Misses 33357 33357
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
4 tasks
ulysses-you
reviewed
Aug 30, 2023
| try { | ||
| // For launch engine operation, we use OperationLog to pass engine submit log but | ||
| // at that time we do not have remoteOpHandle | ||
| getOperationLog.foreach(_.close()) |
Contributor
There was a problem hiding this comment.
what happens if this operation is closed ?
Contributor
Author
There was a problem hiding this comment.
Close the log stream gracefully, then delete the log file
Contributor
Author
There was a problem hiding this comment.
Sorry, I replied to your message but forgot to submit it
ulysses-you
pushed a commit
that referenced
this pull request
Sep 14, 2023
### _Why are the changes needed?_ ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request ### _Was this patch authored or co-authored using generative AI tooling?_ Closes #5211 from ASiegeLion/master. Closes #5210 6366e96 [peiyue liu] Merge branch 'apache:master' into master 34dcc57 [liupeiyue] [KYUUBI #5210]Cancel operation will cause the log file node to leak Lead-authored-by: peiyue liu <945076608@qq.com> Co-authored-by: liupeiyue <liupeiyue@yy.com> Signed-off-by: ulyssesyou <ulyssesyou@apache.org> (cherry picked from commit 721c0a4) Signed-off-by: ulyssesyou <ulyssesyou@apache.org>
ulysses-you
pushed a commit
that referenced
this pull request
Sep 14, 2023
### _Why are the changes needed?_ ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request ### _Was this patch authored or co-authored using generative AI tooling?_ Closes #5211 from ASiegeLion/master. Closes #5210 6366e96 [peiyue liu] Merge branch 'apache:master' into master 34dcc57 [liupeiyue] [KYUUBI #5210]Cancel operation will cause the log file node to leak Lead-authored-by: peiyue liu <945076608@qq.com> Co-authored-by: liupeiyue <liupeiyue@yy.com> Signed-off-by: ulyssesyou <ulyssesyou@apache.org> (cherry picked from commit 721c0a4) Signed-off-by: ulyssesyou <ulyssesyou@apache.org>
Contributor
|
thanks, merged to master/1.8/1.7 |
pan3793
changed the title
This was referenced Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #5210.
The cancel operation may cause log file handle leak
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?