[KYUUBI #5408] MetadataManager tries MySQL 8 driver class first #5433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind:documentation
pan3793
changed the title
pan3793
approved these changes
Oct 16, 2023
Codecov Report
@@ Coverage Diff @@
## master #5433 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 588 588
Lines 33446 33467 +21
Branches 4400 4402 +2
======================================
- Misses 33446 33467 +21
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
@lsm1 the PR itself LGTM, would you mind fixing the conflicts? |
lsm1
force-pushed
the
branch-kyuubi-5408
branch
from
393776f to
20415dc
Compare
Contributor
Author
ok，done |
cxzl25
approved these changes
Oct 17, 2023
pan3793
reviewed
Oct 17, 2023
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStore.scala
Show resolved
Hide resolved
cxzl25
pushed a commit
that referenced
this pull request
Oct 18, 2023
### _Why are the changes needed?_ close #5408 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request ### _Was this patch authored or co-authored using generative AI tooling?_ NO Closes #5433 from lsm1/branch-kyuubi-5408. Closes #5408 8c6cc22 [senmiaoliu] fix style 20415dc [senmiaoliu] use com.mysql.cj.jdbc.Driver first Authored-by: senmiaoliu <senmiaoliu@trip.com> Signed-off-by: Shaoyun Chen <csy@apache.org> (cherry picked from commit 1675216) Signed-off-by: Shaoyun Chen <csy@apache.org>
Contributor
|
Thanks, merged to master/1.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
close #5408
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?
NO