Skip to content

Conversation

@biangjuang
Copy link

Why are the changes needed?

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

Was this patch authored or co-authored using generative AI tooling?

No

@biangjuang
Copy link
Author

biangjuang commented Oct 26, 2023

It's for #5378 ,sorry for late.
@pan3793 hello, would you please help to review this ? I haven't remove the serveronly flag and haven't change the conf flags,I will do that and fix the UT later. Any suggestions are welcome.

@bowenliang123 bowenliang123 marked this pull request as draft October 27, 2023 14:04
@github-actions
Copy link

Thanks for the PR! This PR is being closed due to inactivity. This isn't a judgement on the merit of the PR in any way. If this is still an issue with the latest version of Kyuubi, please reopen it and ask a committer to remove the Stale tag!

Thank you for using Kyuubi!

@github-actions github-actions bot added the Stale label Feb 10, 2024
@github-actions github-actions bot closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant