[KYUUBI #5472][AUTHZ][FOLLOWUP] Check permanent view also need support merge projection #5542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…support merge projection
Contributor
Author
|
ping @yaooqinn |
...uubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/PrivilegesBuilder.scala
Outdated
Show resolved
Hide resolved
bowenliang123
approved these changes
Oct 26, 2023
Codecov Report
@@ Coverage Diff @@
## master #5542 +/- ##
============================================
+ Coverage 61.32% 61.38% +0.06%
Complexity 23 23
============================================
Files 598 598
Lines 34254 34258 +4
Branches 4488 4489 +1
============================================
+ Hits 21006 21030 +24
+ Misses 11122 11102 -20
Partials 2126 2126
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
...uubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/PrivilegesBuilder.scala
Outdated
Show resolved
Hide resolved
…kyuubi/plugin/spark/authz/PrivilegesBuilder.scala Co-authored-by: Bowen Liang <bowenliang@apache.org>
...uubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/PrivilegesBuilder.scala
Outdated
Show resolved
Hide resolved
…kyuubi/plugin/spark/authz/PrivilegesBuilder.scala
Member
|
Merged to master, @AngersZhuuuu could you please open a PR for branch-1.8? this are conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
To close #5472 .
Check permanent view also need support merge projection
For case
SELECT count(id) FROM $db1.$view1 WHERE id > 10we only need to checkid, before this pr, we need to checkid,scope.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?