[WIP][KYUUBI #5605] Add mock output table rule #5605
Conversation
wForget
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5605 +/- ##
============================================
- Coverage 61.69% 61.42% -0.28%
Complexity 23 23
============================================
Files 603 603
Lines 35670 35669 -1
Branches 4869 4869
============================================
- Hits 22005 21908 -97
- Misses 11281 11381 +100
+ Partials 2384 2380 -4 see 29 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| case i @ InsertIntoStatement(r: HiveTableRelation, _, _, _, _, _, _) | ||
| if !isMockTable(r.tableMeta) => | ||
| val newTable = mockTable(r.tableMeta, suffix, true) | ||
| i.copy(table = DDLUtils.readHiveTable(newTable)) |
There was a problem hiding this comment.
We should think about more. For example, the mocked table is not existed, how can we do insert into ?
There was a problem hiding this comment.
mockTable method will create mock table if it does not exist.
wForget
changed the title
|
Thanks for the PR! This PR is being closed due to inactivity. This isn't a judgement on the merit of the PR in any way. If this is still an issue with the latest version of Kyuubi, please reopen it and ask a committer to remove the Stale tag! Thank you for using Kyuubi! |
3 participants
Why are the changes needed?
When debugging SQL tasks, we may need to replace the output table with a test table to avoid overwriting online data.
So I implemented a
MockOutputTablerule to replace the output table with a mock table which ends with_mock_${System.currentTimeMillis()}.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?
No