[KYUUBI #5582] JDBC Engine supports configurable default fetchSize #5614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind:documentation
cxzl25
reviewed
Nov 9, 2023
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
Outdated
Show resolved
Hide resolved
lsm1
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5614 +/- ##
============================================
+ Coverage 61.45% 62.11% +0.65%
Complexity 23 23
============================================
Files 603 604 +1
Lines 35664 36279 +615
Branches 4876 4941 +65
============================================
+ Hits 21916 22533 +617
+ Misses 11375 11374 -1
+ Partials 2373 2372 -1 ☔ View full report in Codecov by Sentry. |
cxzl25
reviewed
Nov 10, 2023
|
|
||
| var defaultFetchSize: Int = 0 | ||
| def get(conf: KyuubiConf): JdbcDialect = { | ||
| defaultFetchSize = conf.get(ENGINE_JDBC_FETCH_SIZE) |
Contributor
There was a problem hiding this comment.
This fetch size may be modified by the conf of different sessions. Can the fetch size be obtained in JdbcOperationManager?
lsm1
force-pushed
the
branch-kyuubi-5582
branch
from
0d6e858 to
9688064
Compare
lsm1
force-pushed
the
branch-kyuubi-5582
branch
from
9688064 to
d0eb7c5
Compare
cxzl25
approved these changes
Nov 13, 2023
bowenliang123
approved these changes
Nov 13, 2023
Contributor
bowenliang123
left a comment
bowenliang123
left a comment
There was a problem hiding this comment.
LGTM.
Minor comments for code readability.
...dbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/operation/JdbcOperationManager.scala
Outdated
Show resolved
Hide resolved
...dbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/operation/JdbcOperationManager.scala
Show resolved
Hide resolved
Contributor
|
Thanks, merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
close #5582
JDBC Engine supports configurable default fetchSize
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?
NO