Skip to content

Conversation

@merrily01
Copy link
Member

Why are the changes needed?

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

Was this patch authored or co-authored using generative AI tooling?

import org.apache.kyuubi.Utils
import org.apache.kyuubi.engine.jdbc.WithJdbcServerContainer

trait WithClickHouseContainer extends WithJdbcServerContainer {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

Merging #5644 (afa55d6) into master (517543a) will increase coverage by 0.05%.
Report is 8 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #5644      +/-   ##
============================================
+ Coverage     61.39%   61.44%   +0.05%     
  Complexity       23       23              
============================================
  Files           603      603              
  Lines         35638    35664      +26     
  Branches       4875     4876       +1     
============================================
+ Hits          21879    21915      +36     
+ Misses        11377    11368       -9     
+ Partials       2382     2381       -1     

see 15 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

<dependency>
<groupId>com.clickhouse</groupId>
<artifactId>clickhouse-jdbc</artifactId>
<classifier>all</classifier>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use the thin one, IIRC, there is a lightweight http client implementation

@github-actions
Copy link

Thanks for the PR! This PR is being closed due to inactivity. This isn't a judgement on the merit of the PR in any way. If this is still an issue with the latest version of Kyuubi, please reopen it and ask a committer to remove the Stale tag!

Thank you for using Kyuubi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants