-
Notifications
You must be signed in to change notification settings - Fork 982
[WIP][KYUUBI #5374] JDBC Engine supports ClickHouse #5644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| import org.apache.kyuubi.Utils | ||
| import org.apache.kyuubi.engine.jdbc.WithJdbcServerContainer | ||
|
|
||
| trait WithClickHouseContainer extends WithJdbcServerContainer { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use testcontainers for Clickhouse testcontainers-scala-clickhouse instead.
refs:
7cc739d to
d9c03ca
Compare
Codecov Report
@@ Coverage Diff @@
## master #5644 +/- ##
============================================
+ Coverage 61.39% 61.44% +0.05%
Complexity 23 23
============================================
Files 603 603
Lines 35638 35664 +26
Branches 4875 4876 +1
============================================
+ Hits 21879 21915 +36
+ Misses 11377 11368 -9
+ Partials 2382 2381 -1 see 15 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
| <dependency> | ||
| <groupId>com.clickhouse</groupId> | ||
| <artifactId>clickhouse-jdbc</artifactId> | ||
| <classifier>all</classifier> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use the thin one, IIRC, there is a lightweight http client implementation
|
Thanks for the PR! This PR is being closed due to inactivity. This isn't a judgement on the merit of the PR in any way. If this is still an issue with the latest version of Kyuubi, please reopen it and ask a committer to remove the Stale tag! Thank you for using Kyuubi! |
Why are the changes needed?
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?