Skip to content

Conversation

@bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Nov 7, 2023

Why are the changes needed?

In practical usage, we often maintain and have some custom dependency library JAR files for logging, authentication, advisors and etc that need to be packaged into the distribution package. This PR supports copying all JAR files from the path ./custom-server-jars to the 'jars' directory of the distribution, which helps automate the packaging process.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

Was this patch authored or co-authored using generative AI tooling?

No.

@bowenliang123 bowenliang123 marked this pull request as draft November 7, 2023 12:17
@pan3793
Copy link
Member

pan3793 commented Nov 7, 2023

This does not like a common practice, especially, why those jars are expected to exist in a folder before packaging? do you plan to track those jars by Git internally?

@bowenliang123 bowenliang123 requested a review from pan3793 November 7, 2023 12:52
@bowenliang123 bowenliang123 marked this pull request as ready for review November 7, 2023 12:52
@bowenliang123
Copy link
Contributor Author

This does not like a common practice, especially, why those jars are expected to exist in a folder before packaging? do you plan to track those jars by Git internally?

It is reasonable to use pre-built library jars for different purposes. Eg. JDBC drivers for authentication , custom server plugin, logger jars and etc.

@codecov-commenter
Copy link

Codecov Report

Merging #5646 (9913eb4) into master (85af9d9) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #5646      +/-   ##
============================================
- Coverage     61.42%   61.36%   -0.06%     
  Complexity       23       23              
============================================
  Files           603      603              
  Lines         35634    35634              
  Branches       4873     4873              
============================================
- Hits          21887    21867      -20     
- Misses        11368    11385      +17     
- Partials       2379     2382       +3     

see 9 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@bowenliang123 bowenliang123 deleted the dist-cp-custom-jars branch November 7, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants