Skip to content

Conversation

@yaooqinn
Copy link
Member

@yaooqinn yaooqinn commented Nov 15, 2023

🔍 Description

Issue References 🔗

This pull request fixes #5701

Describe Your Solution 🔧

This PR updates the PR template to ensure that PR authors provide informative PR descriptions for reviewers to speed up the review process.

It's also suitable for improving our code quality.

Besides, docs/contributing/code/style.rst is also changed to add a link to the doc style so that we can keep the PR template neat.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

See the screenshot below.
image

Behavior With This Pull Request 🎉

It's able to check it from the description of this PR directly.

Related Unit Tests

No


Checklists

📝 Author Self Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • This patch was authored or co-authored using Generative Tooling

📝 Committer Pre-Merge Checklist

  • Pull request title is okay.
  • No license issues.
  • Milestone correctly set?
  • Test coverage is ok
  • Assignees are selected.
  • Minimum number of approvals
  • No changes are requested

Be nice. Be informative.

@github-actions github-actions bot added kind:documentation Documentation is a feature! kind:infra license, community building, project builds, asf infra related, etc. labels Nov 15, 2023
@yaooqinn yaooqinn changed the title [KYUUBI #5701]Enhance PR Template to make PR desc informative [KYUUBI #5701] Enhance the PR Template to make PR desc informative Nov 15, 2023
@yaooqinn yaooqinn added this to the v1.9.0 milestone Nov 15, 2023
@yaooqinn yaooqinn self-assigned this Nov 15, 2023
@bowenliang123
Copy link
Contributor

Missing "Was this patch authored or co-authored using generative AI tooling?" question and the radio options.

@yaooqinn
Copy link
Member Author

It's on the author self checklist

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (905170d) 61.43% compared to head (19bdea9) 61.40%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5702      +/-   ##
============================================
- Coverage     61.43%   61.40%   -0.04%     
  Complexity       23       23              
============================================
  Files           607      607              
  Lines         35727    35727              
  Branches       4891     4891              
============================================
- Hits          21950    21937      -13     
- Misses        11393    11402       +9     
- Partials       2384     2388       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yaooqinn yaooqinn closed this in 10d0aec Nov 15, 2023
@yaooqinn yaooqinn deleted the pr branch November 15, 2023 10:37
@yaooqinn
Copy link
Member Author

Thanks. Merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:documentation Documentation is a feature! kind:infra license, community building, project builds, asf infra related, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] Enhance the PR Template to make PR desc informative

4 participants