Skip to content

Conversation

@zml1206
Copy link
Contributor

@zml1206 zml1206 commented Nov 16, 2023

🔍 Description

Issue References 🔗

This pull request fixes #5707

Describe Your Solution 🔧

org.apache.spark.sql.delta.commands.MergeIntoCommand add uriDescs.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests

org.apache.kyuubi.plugin.spark.authz.ranger.DeltaCatalogRangerSparkExtensionSuite.test("merge into path-based table")


Checklists

📝 Author Self Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • This patch was not authored or co-authored using Generative Tooling

📝 Committer Pre-Merge Checklist

  • Pull request title is okay.
  • No license issues.
  • Milestone correctly set?
  • Test coverage is ok
  • Assignees are selected.
  • Minimum number of approvals
  • No changes are requested

Be nice. Be informative.

@yaooqinn yaooqinn added this to the v1.9.0 milestone Nov 16, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (23f32cf) 61.43% compared to head (45ab4d4) 61.43%.

Files Patch % Lines
...yuubi/plugin/spark/authz/serde/uriExtractors.scala 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5708      +/-   ##
============================================
- Coverage     61.43%   61.43%   -0.01%     
  Complexity       23       23              
============================================
  Files           607      607              
  Lines         35735    35739       +4     
  Branches       4896     4896              
============================================
+ Hits          21955    21956       +1     
- Misses        11402    11408       +6     
+ Partials       2378     2375       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yaooqinn yaooqinn closed this in d4dd1cb Nov 20, 2023
@yaooqinn
Copy link
Member

thanks, merged to master

@zml1206
Copy link
Contributor Author

zml1206 commented Nov 20, 2023

Thanks, @yaooqinn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TASK][EASY] Support merge into path-based table for Delta Lake in Authz

3 participants