[KYUUBI #5244][1.8] Make engineAliveMaxFailCount configurable #5888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urable ### _Why are the changes needed?_ close apache#5244 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request ### _Was this patch authored or co-authored using generative AI tooling?_ No Closes apache#5251 from lsm1/branch-kyuubi-5244. Closes apache#5244 bcadaa5 [senmiaoliu] rename a6c9277 [senmiaoliu] fix style 1f38fa7 [senmiaoliu] fix style 3ff57ff [senmiaoliu] Make engineAliveMaxFailCount configurable Authored-by: senmiaoliu <senmiaoliu@trip.com> Signed-off-by: Shaoyun Chen <csy@apache.org> (cherry picked from commit 9ea0a1b)
github-actions
bot
added
kind:documentation
cxzl25
approved these changes
Dec 21, 2023
pan3793
changed the title
pan3793
reviewed
Dec 21, 2023
| val ENGINE_ALIVE_MAX_FAILURES: ConfigEntry[Int] = | ||
| buildConf("kyuubi.session.engine.alive.max.failures") | ||
| .doc("The maximum number of failures allowed for the engine.") | ||
| .version("1.8.0") |
Member
There was a problem hiding this comment.
due to the merging issue, this is invalid, we need a followup PR to fix it as 1.8.1
pan3793
pushed a commit
that referenced
this pull request
Dec 21, 2023
### _Why are the changes needed?_ close #5244 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request ### _Was this patch authored or co-authored using generative AI tooling?_ No Closes #5251 from lsm1/branch-kyuubi-5244. Closes #5244 bcadaa5 [senmiaoliu] rename a6c9277 [senmiaoliu] fix style 1f38fa7 [senmiaoliu] fix style 3ff57ff [senmiaoliu] Make engineAliveMaxFailCount configurable Authored-by: senmiaoliu <senmiaoliutrip.com> Signed-off-by: Shaoyun Chen <csyapache.org> (cherry picked from commit 9ea0a1b) Closes #5888 from wForget/dev-1.8_backport_5251. Closes #5244 cf9c725 [senmiaoliu] [KYUUBI #5244][Improvement] Make engineAliveMaxFailCount configurable Authored-by: senmiaoliu <senmiaoliu@trip.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
Member
|
Merged to 1.8 |
18 tasks
pan3793
pushed a commit
that referenced
this pull request
Dec 21, 2023
…sion # 🔍 Description ## Issue References 🔗 This pull request fixes #5244 ## Describe Your Solution 🔧 As discussed in #5888 (comment), we need to correct the ENGINE_ALIVE_MAX_FAILURES conf version. ## Types of changes 🔖 - [X] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklists ## 📝 Author Self Checklist - [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project - [x] I have performed a self-review - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) ## 📝 Committer Pre-Merge Checklist - [x] Pull request title is okay. - [x] No license issues. - [x] Milestone correctly set? - [x] Test coverage is ok - [x] Assignees are selected. - [x] Minimum number of approvals - [x] No changes are requested **Be nice. Be informative.** Closes #5889 from wForget/KYUUBI-5244-FOLLOWUP. Closes #5244 a785449 [wforget] [KYUUBI #5244][FOLLOWUP] Corrected ENGINE_ALIVE_MAX_FAILURES conf version Authored-by: wforget <643348094@qq.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
pan3793
pushed a commit
that referenced
this pull request
Dec 21, 2023
…sion # 🔍 Description ## Issue References 🔗 This pull request fixes #5244 ## Describe Your Solution 🔧 As discussed in #5888 (comment), we need to correct the ENGINE_ALIVE_MAX_FAILURES conf version. ## Types of changes 🔖 - [X] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklists ## 📝 Author Self Checklist - [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project - [x] I have performed a self-review - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) ## 📝 Committer Pre-Merge Checklist - [x] Pull request title is okay. - [x] No license issues. - [x] Milestone correctly set? - [x] Test coverage is ok - [x] Assignees are selected. - [x] Minimum number of approvals - [x] No changes are requested **Be nice. Be informative.** Closes #5889 from wForget/KYUUBI-5244-FOLLOWUP. Closes #5244 a785449 [wforget] [KYUUBI #5244][FOLLOWUP] Corrected ENGINE_ALIVE_MAX_FAILURES conf version Authored-by: wforget <643348094@qq.com> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 7b7e17b) Signed-off-by: Cheng Pan <chengpan@apache.org>
zhaohehuhu
pushed a commit
to zhaohehuhu/incubator-kyuubi
that referenced
this pull request
Mar 21, 2024
…nf version # 🔍 Description ## Issue References 🔗 This pull request fixes apache#5244 ## Describe Your Solution 🔧 As discussed in apache#5888 (comment), we need to correct the ENGINE_ALIVE_MAX_FAILURES conf version. ## Types of changes 🔖 - [X] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklists ## 📝 Author Self Checklist - [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project - [x] I have performed a self-review - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) ## 📝 Committer Pre-Merge Checklist - [x] Pull request title is okay. - [x] No license issues. - [x] Milestone correctly set? - [x] Test coverage is ok - [x] Assignees are selected. - [x] Minimum number of approvals - [x] No changes are requested **Be nice. Be informative.** Closes apache#5889 from wForget/KYUUBI-5244-FOLLOWUP. Closes apache#5244 a785449 [wforget] [KYUUBI apache#5244][FOLLOWUP] Corrected ENGINE_ALIVE_MAX_FAILURES conf version Authored-by: wforget <643348094@qq.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
close #5244
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?
No
Closes #5251 from lsm1/branch-kyuubi-5244.
Closes #5244
bcadaa5 [senmiaoliu] rename
a6c9277 [senmiaoliu] fix style
1f38fa7 [senmiaoliu] fix style
3ff57ff [senmiaoliu] Make engineAliveMaxFailCount configurable
Authored-by: senmiaoliu senmiaoliu@trip.com
Signed-off-by: Shaoyun Chen csy@apache.org
(cherry picked from commit 9ea0a1b)