Generate flattened POM #6416
Closed
Generate flattened POM #6416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind:infra
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6416 +/- ##
============================================
- Coverage 58.33% 58.29% -0.04%
Complexity 24 24
============================================
Files 656 656
Lines 40267 40267
Branches 5498 5498
============================================
- Hits 23489 23474 -15
Misses 14277 14277
- Partials 2501 2516 +15 ☔ View full report in Codecov by Sentry. |
bowenliang123
approved these changes
May 24, 2024
pan3793
added a commit
that referenced
this pull request
May 24, 2024
# 🔍 Description Leverage [Flatten Maven Plugin](https://www.mojohaus.org/flatten-maven-plugin/) to generate resolved `pom.xml`. This recovers a dev case for Scala 2.13. We usually perform `clean install` with `-am` and `-DskipTests` one time and perform `test` after changing code on specific modules, e.g. ``` build/mvn -Pscala-2.13 -pl externals/kyuubi-spark-sql-engine clean install -am -DskipTests build/mvn -Pscala-2.13 -pl externals/kyuubi-spark-sql-engine test ``` Currently, the second step wrongly resolves to `*_2.12` dependencies due to the installed `pom.xml` referring to `*_${scala.binary.version}` while the default value of `scala.binary.version` is `2.12`. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 This change is verified locally by the above case. --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6416 from pan3793/flatten. Closes #6416 db7020c [Cheng Pan] Generate flattened pom.xml Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 4702f5a) Signed-off-by: Cheng Pan <chengpan@apache.org>
Member
Author
|
Thanks, merged to master/1.9 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Leverage Flatten Maven Plugin to generate resolved
pom.xml.This recovers a dev case for Scala 2.13.
We usually perform
clean installwith-amand-DskipTestsone time and performtestafter changing code on specific modules, e.g.Currently, the second step wrongly resolves to
*_2.12dependencies due to the installedpom.xmlreferring to*_${scala.binary.version}while the default value ofscala.binary.versionis2.12.Types of changes 🔖
Test Plan 🧪
This change is verified locally by the above case.
Checklist 📝
Be nice. Be informative.