Skip to content

Conversation

@huangxiaopingRD
Copy link
Contributor

@huangxiaopingRD huangxiaopingRD commented Jul 18, 2024

🔍 Description

Issue References 🔗

This pull request fixes #6546

Describe Your Solution 🔧

Fix incorrect documentation description.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@pan3793
Copy link
Member

pan3793 commented Jul 18, 2024

please write the concrete content in the Issue/PR title and description, it makes no sense to just say "fix docs", "fix bugs", "add a new awesome feature".

BTW, the style issue could be fixed by dev/reformat

@huangxiaopingRD huangxiaopingRD changed the title [KYUUBI #6546] Fix incorrect documentation description [KYUUBI #6546] Update incorrect descriptions in Zorder related configurations Jul 18, 2024
@huangxiaopingRD
Copy link
Contributor Author

please write the concrete content in the Issue/PR title and description, it makes no sense to just say "fix docs", "fix bugs", "add a new awesome feature".

BTW, the style issue could be fixed by dev/reformat

@pan3793 Thank you for your suggestion and review, it has been updated.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (1309819) to head (fab3b93).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6547   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         677     677           
  Lines       41797   41797           
  Branches     5708    5708           
======================================
  Misses      41797   41797           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan3793 pan3793 added this to the v1.10.0 milestone Jul 19, 2024
@pan3793 pan3793 closed this in 4040acb Jul 19, 2024
@pan3793
Copy link
Member

pan3793 commented Jul 19, 2024

Thanks, merged to master

@huangxiaopingRD huangxiaopingRD deleted the 6546 branch July 19, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update incorrect descriptions in Zorder related configurations

3 participants