[KYUUBI #7403] Password with colon bug fixes#7404
Closed
oh0873 wants to merge 1 commit intoapache:masterfrom
Closed
[KYUUBI #7403] Password with colon bug fixes#7404oh0873 wants to merge 1 commit intoapache:masterfrom
oh0873 wants to merge 1 commit intoapache:masterfrom
Conversation
pan3793
approved these changes
Apr 16, 2026
pan3793
pushed a commit
that referenced
this pull request
Apr 16, 2026
### Why are the changes needed? If a password contains a colon, REST API does not pick up colons. Similarly, password string like `correctpassword:random-charachars` gets parsed as `correctpassword`. ### How was this patch tested? Tested in local build, password with colon are getting parsed properly. ### Was this patch authored or co-authored using generative AI tooling? Test Suite was helped by Cursor auto-complete. Closes #7404 from oh0873/hoonoh/colon-password-bug-fix. Closes #7403 1bd8e19 [Hoon Oh] Password with colon bug fixes Authored-by: Hoon Oh <hoonoh@geico.com> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 80ff8b3) Signed-off-by: Cheng Pan <chengpan@apache.org>
pan3793
pushed a commit
that referenced
this pull request
Apr 16, 2026
### Why are the changes needed? If a password contains a colon, REST API does not pick up colons. Similarly, password string like `correctpassword:random-charachars` gets parsed as `correctpassword`. ### How was this patch tested? Tested in local build, password with colon are getting parsed properly. ### Was this patch authored or co-authored using generative AI tooling? Test Suite was helped by Cursor auto-complete. Closes #7404 from oh0873/hoonoh/colon-password-bug-fix. Closes #7403 1bd8e19 [Hoon Oh] Password with colon bug fixes Authored-by: Hoon Oh <hoonoh@geico.com> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 80ff8b3) Signed-off-by: Cheng Pan <chengpan@apache.org>
Member
|
thanks, merged to master/1.11.2/1.10.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
If a password contains a colon, REST API does not pick up colons. Similarly, password string like
correctpassword:random-characharsgets parsed ascorrectpassword.How was this patch tested?
Tested in local build, password with colon are getting parsed properly.
Was this patch authored or co-authored using generative AI tooling?
Test Suite was helped by Cursor auto-complete.