Skip to content

GCENodeDriver's deploy_node() should accept Deployments and other parameters that are accepted by create_node() #1381

@yukw777

Description

@yukw777

Feature Request

I was trying to use Deployment when launching nodes using GCE, but I noticed that the deploy_node() of GCENodeDriver has a different function signature from other drivers and does not accept Deployment. Furthermore, it doesn't accept other essential parameters you can pass in to create_node(), making it very limited in its usefulness. Is there a reason why this is so? I fail to see why GCENodeDriver has overridden NodeDriver's default deploy_node() when there is even this comment:

Deploy node is typically not overridden in subclasses. The

I think GCENodeDriver should accept Deployment for its deploy_node() method like other drivers. Would this be as simple as removing the overriding method? Thank you for your help in advance!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions