fix path for profitbricks list_snapshots() method#1153
fix path for profitbricks list_snapshots() method#1153thehunmonkgroup wants to merge 1 commit intoapache:trunkfrom
Conversation
leading slash breaks the URL
|
Thanks! Do you think you could add a test? |
|
I poked around the testing code, and wasn't really able to understand how y'all have it set up. I see there is already a test in there for listing snapshots, but I'm guessing it's wrong or already failing, and I don't really understand how to fix it. I'm sorry, I'm not willing to spend any more time on the learning curve. |
|
Thank you for your honesty. |
|
sure thing, i hope my current contribution can make it into a fix. |
|
We're currently lacking reviewers so no PR has been merged for more than a month. Hopefully this situation will change at some point. |
|
It turns out that it's not easy to add a test here, because the fixture will be the same with and without the slash. I decided to merge this as is in trunk. Thanks! |
Fix path for profitbricks compute driver
list_snapshotsmethodDescription
The leading slash breaks the URL in this method. With it, I get:
Removing the slash makes the method work again, and it's in line with the format of the other API requests in the driver that omit the full URL.
Status
Checklist (tick everything that applies)