implement attach/detach floating IPs for DO#1191
Closed
vdloo wants to merge 1 commit intoapache:trunkfrom
Closed
Conversation
vdloo
force-pushed
the
implement-attach-detach-floating-ip-for-do
branch
from
dcb8631 to
56611af
Compare
add methods to the DigitalOcean_v2_NodeDriver to attach and detach floating IPs from instances uniform to the `ex_attach_floating_ip_to_node` and `ex_detach_floating_ip_from_node` methods from the [OpenStack_1_1_NodeDriver](https://github.com/apache/libcloud/blob/2b298b7cd8d17b4b1c0db20292fdb7867a512ac6/libcloud/compute/drivers/openstack.py#L2394) see https://developers.digitalocean.com/documentation/v2/#assign-a-floating-ip-to-a-droplet and https://developers.digitalocean.com/documentation/v2/#unassign-a-floating-ip
vdloo
force-pushed
the
implement-attach-detach-floating-ip-for-do
branch
from
56611af to
b262444
Compare
Codecov Report
@@ Coverage Diff @@
## trunk #1191 +/- ##
=========================================
+ Coverage 86.19% 86.2% +0.01%
=========================================
Files 348 348
Lines 67266 67292 +26
Branches 5958 5958
=========================================
+ Hits 57980 58010 +30
+ Misses 6853 6850 -3
+ Partials 2433 2432 -1
Continue to review full report at Codecov.
|
pquentin
reviewed
Mar 21, 2018
| return (httplib.CREATED, body, {}, httplib.responses[httplib.CREATED]) | ||
| else: | ||
| raise NotImplementedError() | ||
|
|
Contributor
There was a problem hiding this comment.
Out of scope for this pull request, but I'm not a huge fan of this style because the raise path is never exercised and lowers the coverage. I think I'd prefer something like assert method in ['GET', 'POST'] at the beginning of the function. Not sure it's worth the trouble, and for now consistency is better!
Contributor
|
Thanks, merged in trunk! ✨ |
famanson
pushed a commit
to esplorio/libcloud
that referenced
this pull request
Apr 13, 2018
* 'trunk' of github.com:apache/libcloud: (1281 commits) Add changes for apache#1196 Added ability to define OS disk size for Azure ARM compute Add changes for apache#1198 Google Cloud DNS documentation test_s3: Fix lint Fix one GCE test fix spelling in OpenStack ex_files description Add changes for apache#1181 [LIBCLOUD-985] Add coverage for newer GCE network and subnet creation options. LIBCLOUD-986: Fix S3 iteration without prefix Add changes for apache#1195 guess s3 multipart upload content type. Add changes for apache#1193 LIBCLOUD-986: Add prefix option to azure blob list and iterate container methods Add changes for apache#1143 [LIBCLOUD-961] Update GCE public image list. Add changes for apache#1190 fix unexpected body type openstack image sharing Add changes for apache#1191 implement attach/detach floating IPs for DO ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add methods to the DigitalOcean_v2_NodeDriver to attach and detach floating IPs from instances uniform to the
ex_attach_floating_ip_to_nodeandex_detach_floating_ip_from_nodemethods from the OpenStack_1_1_NodeDriversee https://developers.digitalocean.com/documentation/v2/#assign-a-floating-ip-to-a-droplet and https://developers.digitalocean.com/documentation/v2/#unassign-a-floating-ip
cc @AlexanderGrooff