Skip to content

openstack: document openstack_connection_kwargs#1219

Merged
asfgit merged 1 commit intoapache:trunkfrom
ktdreyer:doc-openstack-connection-kwargs
Jun 28, 2018
Merged

openstack: document openstack_connection_kwargs#1219
asfgit merged 1 commit intoapache:trunkfrom
ktdreyer:doc-openstack-connection-kwargs

Conversation

@ktdreyer
Copy link
Copy Markdown
Contributor

@ktdreyer ktdreyer commented Jun 26, 2018

openstack: document openstack_connection_kwargs

Description

OpenStackDriverMixin has a openstack_connection_kwargs() method. Document what it does.

Status

done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

OpenStackDriverMixin has a openstack_connection_kwargs() method.
Document what it does.
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1219 into trunk will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk    #1219   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files         350      350           
  Lines       67755    67755           
  Branches     5980     5980           
=======================================
  Hits        58458    58458           
  Misses       6858     6858           
  Partials     2439     2439
Impacted Files Coverage Δ
libcloud/common/openstack.py 82.35% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc097ff...90378f3. Read the comment docs.

@pquentin
Copy link
Copy Markdown
Contributor

@vdloo Would you like to review and merge this change?

@vdloo
Copy link
Copy Markdown
Member

vdloo commented Jun 28, 2018

lgtm 👍

@asfgit asfgit merged commit 90378f3 into apache:trunk Jun 28, 2018
asfgit pushed a commit that referenced this pull request Jun 28, 2018
@vdloo
Copy link
Copy Markdown
Member

vdloo commented Jun 28, 2018

Thanks! Merged in trunk. ✨

asfgit pushed a commit that referenced this pull request Jun 28, 2018
asfgit pushed a commit that referenced this pull request Jun 30, 2018
This was accidentally placed under the Apache Libcloud 2.3.0 release
notes instead of development.
@ktdreyer ktdreyer deleted the doc-openstack-connection-kwargs branch July 12, 2018 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants