Fix case where node does not exist on OpenStack#864
Closed
allardhoeve wants to merge 2 commits intoapache:trunkfrom
Closed
Fix case where node does not exist on OpenStack#864allardhoeve wants to merge 2 commits intoapache:trunkfrom
allardhoeve wants to merge 2 commits intoapache:trunkfrom
Conversation
allardhoeve
force-pushed
the
os-stop-node
branch
from
e9b0886 to
84e1544
Compare
- Add case where the node does not exist on OS - Fix code that tries to return None if the node does not exist
Contributor
Author
|
Branch has the wrong name. Fixing OS stop node will be the next fix 😄 |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix OpenStack
ex_get_node_detailsfor non-existing nodesDescription
Status
Checklist (tick everything that applies)