Fixed an infinite loop in "Transcoder::encode"#34
Merged
ams-tschoening merged 3 commits intomasterfrom Aug 9, 2020
Merged
Conversation
…wstring&)" by appending LOSSCHAR. The most likely alternative would be to throw on any invalid input instead, but that's not the case right now and LOSSCHAR used in other places as well. https://issues.apache.org/jira/browse/LOGCXX-398
Contributor
|
Looks good to me - I went and added a test case as well to validate that it works correctly, if you want to take a look. |
ams-tschoening
commented
Aug 9, 2020
Contributor
Author
ams-tschoening
left a comment
ams-tschoening
left a comment
There was a problem hiding this comment.
This introduced spaces instead of tabs, which I have changed now. The current code style uses tabs, if that should be changed, this needs to be done for the whole codebase and the files .astylerc and .editorconfig need to be adopted. While I prefer tabs in most cases, one should make sure to use some editor honoring .editorconfig.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transcoder::encode(const LogString&, std::wstring&)" by appending LOSSCHAR. The most likely alternative would be to throw on any invalid input instead, but that's not the case right now and LOSSCHAR used in other places as well.
https://issues.apache.org/jira/browse/LOGCXX-398