Conversation
ams-tschoening
left a comment
There was a problem hiding this comment.
Things look good in general to me, though I have some minor suggestions and questions.
How do you plan to handle obsolete parts of ANT, MVN etc.? With an additional PR or make it part of this or ...?
CMakeLists.txt
Outdated
| set(CPACK_SOURCE_IGNORE_FILES ".git/;build/") | ||
| include(CPack) | ||
|
|
||
| add_custom_target( dist |
There was a problem hiding this comment.
How do you execute that target, on the shell and with which command? Visual Studio doesn't seem to provide anything obvious in its UI, installing doesn't seem to trigger that target. Adding ALL like for Doxygen does, but that's not what you intended?
There was a problem hiding this comment.
At least on *nix, this creates a 'make dist' target. With Visual Studio, you need to switch to 'CMake Targets View' in the Solution Explorer. You can then run the target from there.
There was a problem hiding this comment.
thanks, found it with a little help:
I was going to do that as a separate PR, as I was only focusing on the website building with this PR. |





This PR does the following: