Skip to content

Improve Logger interface consistency in the next ABI #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swebb2066 merged 1 commit into from
Nov 10, 2025
Merged

Improve Logger interface consistency in the next ABI #562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/main/cpp/logger.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,10 +327,17 @@ const LevelPtr& Logger::getEffectiveLevel() const
#endif
}

#if LOG4CXX_ABI_VERSION <= 15
LoggerRepository* Logger::getLoggerRepository() const
{
return m_priv->repositoryRaw;
}
#else
LoggerRepositoryPtr Logger::getLoggerRepository()
{
return LogManager::getLoggerRepository();
}
#endif

LoggerRepository* Logger::getHierarchy() const
{
Expand Down
9 changes: 9 additions & 0 deletions src/main/include/log4cxx/logger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,11 +843,13 @@ class LOG4CXX_EXPORT Logger
*/
virtual const LevelPtr& getEffectiveLevel() const;

#if LOG4CXX_ABI_VERSION <= 15
/**
Return the the LoggerRepository where this
<code>Logger</code> is attached.
*/
spi::LoggerRepository* getLoggerRepository() const;
#endif

/**
* Get the logger name.
Expand Down Expand Up @@ -898,6 +900,13 @@ class LOG4CXX_EXPORT Logger
*/
const LevelPtr& getLevel() const;

#if 15 < LOG4CXX_ABI_VERSION
/**
The object that holds all Logger instances.
*/
static spi::LoggerRepositoryPtr getLoggerRepository();
#endif

/**
* Retrieve a logger by name in current encoding.
* @param name logger name.
Expand Down
Loading