Add a chart to the web-site performance data #567
Conversation
|
The staging web-site is available for review |
| benchmark_pattern.push(new RegExp("Async, Sending (.*) using ([A-Za-z <]+)$")); | ||
| const value_regex_pattern = new RegExp("([0-9]+) ns") | ||
|
|
||
| // Extract the data |
There was a problem hiding this comment.
some thoughts:
- instead of extracting the data from the table, we can have a JSON file generated from the benchmark application that can easily be sucked into the JS code
- if we generate the JSON file, should we just generate the table on the fly? this could be done with a simple python script during the build process if we want to keep the data static.
There was a problem hiding this comment.
It is simpler (zero maintenance) to use the data in the page to generate the graph.
There was a problem hiding this comment.
test code kept intentionally?
There was a problem hiding this comment.
I found a test was necessary to quickly iterate through the vast landscape of echarts options. I am agnostic on whether it should be in the repository.
swebb2066
left a comment
swebb2066
left a comment
There was a problem hiding this comment.
Generating the graph on the client side using echarts.js have the minor downside of the download cost of the 1.5MB echarts.js file.
Generating a .png using python has the downside of requiring python+matplotlib being available when publishing the web-site.
I am not sure which to prefer.
The compressed echarts is only 540k: https://echarts.apache.org/en/builder.html |
3 participants
This PR add a chart generated on the client side from data in the html table.