bound parameter buffer size before narrowing to SQLINTEGER#633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bounds ODBC-reported parameter sizes before converting to
SQLINTEGER.Problem
Parameter sizes are obtained as
SQLULENbut later converted toSQLINTEGER.The previous computation performed arithmetic and narrowing without enforcing
the
SQLINTEGERrange, which could produce invalid (overflowed) sizes forout-of-range metadata.
Change
size_tmax_chars = (INT_MAX - sizeof(CharT)) / sizeof(CharT)SQLINTEGERonly after ensuring it is in rangecharandwchar_tpathsBehavior
producing invalid sizes
Notes
palloc(paramValueSize + sizeof(CharT)))