#643 Log complete messages with embedded nul characters in console writers#658
Merged
Conversation
Contributor
|
I think moving the duplicated Note that both implementations are currently |
swebb2066
reviewed
May 14, 2026
|
|
||
| { | ||
| FILE *fp = fopen(path.c_str(), "wb"); | ||
| size_t written = helpers::writeToConsole(false, message, fp); |
Contributor
There was a problem hiding this comment.
This should be:
LOG4CXX_DECODE_CHAR(lsMessage, message);
size_t written = helpers::writeToConsole(lsMessage, fp);
…em.out and system.err writers
swebb2066
reviewed
May 19, 2026
| #include "../logunit.h" | ||
|
|
||
| #include <log4cxx/private/consolewriter_priv.h> | ||
| #include <log4cxx/helpers/pool.h> |
Contributor
There was a problem hiding this comment.
Just need the following
#include <log4cxx/helpers/transcoder.h>
Removed unnecessary includes and preprocessor directives.
Removed unused includes and preprocessor directives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #643
Writes to stdout and stderr now go through fwrite rather than fputs. This stops embedded nul characters in log messages from truncating the rest of the message. Added a regression test
testWriteEmbeddedNullCharactersto go along with the changes.