Merged
Conversation
Added macros "LOG4CXX_VERSION_{MAJOR,MINOR,PATCH,TWEAK}", "LOG4CXX_MAKE_VERSION", "LOG4CXX_VERSION", and "NXT_LOG4CXX_VERSION_GET_{MAJOR,MINOR,PATCH,TWEAK}". These macros provide compile-time version information for log4cxx, necessary for the proper compilation of client code that is sensitive to version-dependent details of log4cxx (for example, the return type of "Logger::getLogger") or simply needs to report the version of log4cxx being used in the compilation.
Upstream cmake downloads the resource. This patch first tries to find a system-installed version before falling back to the download. Exchanging the md5 with a more secure sha256 checksum. Jira: LOGCXX-539 Co-authored-by: Tobias Frost <tobi@debian.org>
… for cmake/pkgconfig target (apache#77) Co-authored-by: Tobias Frost <tobi@debian.org>
…x into jmdavison46-patch-1
jmdavison46
commented
Dec 11, 2021
Contributor
Author
jmdavison46
left a comment
jmdavison46
left a comment
There was a problem hiding this comment.
Suggestion: wrap each argument to LOG4CXX_MAKE_VERSION in parentheses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added macros "LOG4CXX_VERSION_{MAJOR,MINOR,PATCH,TWEAK}", "LOG4CXX_MAKE_VERSION", "LOG4CXX_VERSION", and "NXT_LOG4CXX_VERSION_GET_{MAJOR,MINOR,PATCH,TWEAK}". These macros provide compile-time version information for log4cxx, necessary for the proper compilation of client code that is sensitive to version-dependent details of log4cxx (for example, the return type of "Logger::getLogger") or simply needs to report the version of log4cxx being used in the compilation.