Skip to content

Conversation

@coldtobi
Copy link
Contributor

As many of the individual testsuite uses the same output file for the artifacts
of the test suites, the tests are racy if executed in parallel, eg. by ctest
-jxx. This patch fixes it by assigning individual names for the test artifact
files.

Jira-Issue: LOGCXX-538

As many of the individual testsuite uses the same output file for the artifacts
of the test suites, the tests are racy if executed in parallel, eg. by ctest
-jxx.  This patch fixes it by assigning individual names for the test artifact
files.

Jira-Issue: LOGCXX-538
@coldtobi
Copy link
Contributor Author

I need to investigate why the test suite failed. Will reopen PR once ready.

@coldtobi coldtobi closed this Dec 11, 2021
@coldtobi
Copy link
Contributor Author

(Closing nuked the ci logs .... Reopening to get them again....)

@coldtobi coldtobi reopened this Dec 11, 2021
@ams-tschoening
Copy link
Contributor

Looks like you have simply missed to change src/test/resources/input/patternLayout13.properties? I find all the other files changed, but not this one.

@coldtobi
Copy link
Contributor Author

coldtobi commented Dec 11, 2021

Looks like you have simply missed to change src/test/resources/input/patternLayout13.properties? I find all the other files changed, but not this one.

Good catch! Thanks!

@coldtobi
Copy link
Contributor Author

The failing testcase on ubuntu-18.04-g++-build-and-test is likely LOGCXX-322
2021-12-11T15:44:14.6741094Z 20 - multithreadtest (SEGFAULT)

(I've commented on LOGCXX-322 earlier today)

@coldtobi
Copy link
Contributor Author

@ams-tschoening do you want to take another look or did I miss an open point? (dead lock avoidance)

@ams-tschoening
Copy link
Contributor

Things look fine for me and running tests on my system still works. Regarding the segfault, let's just ignore it for now as part of this PR and merge?

Besides that, propertiestestcase is changed here and in PR #85, resulting in a conflict most likely. Any preference about which one to merge first? I would simply do this one and adopt the other PR.

@coldtobi
Copy link
Contributor Author

coldtobi commented Dec 18, 2021 via email

@ams-tschoening ams-tschoening merged commit 37f3241 into apache:master Dec 18, 2021
@coldtobi coldtobi deleted the LOGCXX-538-testsuite-parallel branch January 8, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants