Skip to content

AbstractRolloverStrategy - return early without IO access, resolves #1280#1143

Closed
lrgrz wants to merge 1 commit intoapache:release-2.xfrom
lrgrz:lrgrz-patch-1
Closed

AbstractRolloverStrategy - return early without IO access, resolves #1280#1143
lrgrz wants to merge 1 commit intoapache:release-2.xfrom
lrgrz:lrgrz-patch-1

Conversation

@lrgrz
Copy link
Copy Markdown

@lrgrz lrgrz commented Nov 18, 2022

return early without IO access, Fixes #1280

@lrgrz lrgrz changed the title Update AbstractRolloverStrategy.java AbstractRolloverStrategy - return early without IO access Nov 21, 2022
Copy link
Copy Markdown
Member

@rgoers rgoers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a Jira issue to track it.

@jvz
Copy link
Copy Markdown
Member

jvz commented Jan 14, 2023

Can you file a GitHub issue for this to describe the change? It'll be for our changelog.

@jvz jvz added the enhancement Additions or updates to features label Jan 14, 2023
@jvz jvz added this to the 2.20.0 milestone Jan 14, 2023
@lrgrz lrgrz changed the title AbstractRolloverStrategy - return early without IO access AbstractRolloverStrategy - return early without IO access, resolves #1280 Feb 19, 2023
@lrgrz
Copy link
Copy Markdown
Author

lrgrz commented Feb 26, 2023

Can you file a GitHub issue for this to describe the change? It'll be for our changelog.

Sure, I've linked pull request to the issue: #1280

@vy vy deleted the branch apache:release-2.x February 28, 2023 15:02
@vy vy closed this Feb 28, 2023
@ppkarwasz
Copy link
Copy Markdown
Contributor

@lrgrz,

This was closed automatically by Github because we renamed the release-2.x branch to 2.x. Feel free to resubmit to the 2.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Additions or updates to features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessary AbstractRolloverStrategy IO access

5 participants