LOG4J2-2312 LOG4J2-2341 Fix jackson layout with async loggers#187
Closed
carterkozak wants to merge 1 commit intoapache:masterfrom
Closed
LOG4J2-2312 LOG4J2-2341 Fix jackson layout with async loggers#187carterkozak wants to merge 1 commit intoapache:masterfrom
carterkozak wants to merge 1 commit intoapache:masterfrom
Conversation
carterkozak
force-pushed
the
LOG4J2-2312_LOG4J2-2341
branch
from
fd1006b to
cb88f99
Compare
carterkozak
added a commit
to carterkozak/logging-log4j2
that referenced
this pull request
Jul 3, 2018
AsyncLoggerContextSelector RingBufferLogEvents were not properly handled by the jackson layout. Currently the jackson layout implementation requires Log4jLogEvent instances, so we must convert all other LogEvent implementations into these. This closes apache#187
carterkozak
commented
Jul 3, 2018
| <groupId>com.lmax</groupId> | ||
| <artifactId>disruptor</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> |
Contributor
Author
There was a problem hiding this comment.
Required to construct a RingBufferLogEvent
carterkozak
force-pushed
the
LOG4J2-2312_LOG4J2-2341
branch
from
cb88f99 to
7957a29
Compare
carterkozak
added a commit
to carterkozak/logging-log4j2
that referenced
this pull request
Jul 3, 2018
AsyncLoggerContextSelector RingBufferLogEvents were not properly handled by the jackson layout. Currently the jackson layout implementation requires Log4jLogEvent instances, so we must convert all other LogEvent implementations into these. This closes apache#187
carterkozak
force-pushed
the
LOG4J2-2312_LOG4J2-2341
branch
from
7957a29 to
306b4f3
Compare
carterkozak
added a commit
to carterkozak/logging-log4j2
that referenced
this pull request
Jul 3, 2018
AsyncLoggerContextSelector RingBufferLogEvents were not properly handled by the jackson layout. Currently the jackson layout implementation requires Log4jLogEvent instances, so we must convert all other LogEvent implementations into these. This closes apache#187
AsyncLoggerContextSelector RingBufferLogEvents were not properly handled by the jackson layout. Currently the jackson layout implementation requires Log4jLogEvent instances, so we must convert all other LogEvent implementations into these. This closes apache#187
carterkozak
force-pushed
the
LOG4J2-2312_LOG4J2-2341
branch
from
306b4f3 to
f135c0f
Compare
asfgit
pushed a commit
that referenced
this pull request
Jul 3, 2018
AsyncLoggerContextSelector RingBufferLogEvents were not properly handled by the jackson layout. Currently the jackson layout implementation requires Log4jLogEvent instances, so we must convert all other LogEvent implementations into these. This closes #187
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AsyncLoggerContextSelector RingBufferLogEvents were not properly
handled by the jackson layout. Currently the jackson layout
implementation requires Log4jLogEvent instances, so we must
convert all other LogEvent implementations into these.