Conversation
ppkarwasz
requested changes
Nov 20, 2023
Contributor
ppkarwasz
left a comment
ppkarwasz
left a comment
There was a problem hiding this comment.
LGTM, but I would keep the two tests below, since they have nothing to do with log4j-web: they use the Servlet API as a way to test HTTP components.
...-test/src/test/java/org/apache/logging/log4j/core/filter/HttpThreadContextMapFilterTest.java
Show resolved
Hide resolved
log4j-core-test/src/test/java/org/apache/logging/log4j/core/net/UrlConnectionFactoryTest.java
Show resolved
Hide resolved
ppkarwasz
approved these changes
Nov 21, 2023
...-test/src/test/java/org/apache/logging/log4j/core/filter/HttpThreadContextMapFilterTest.java
Outdated
Show resolved
Hide resolved
...-test/src/test/java/org/apache/logging/log4j/core/filter/HttpThreadContextMapFilterTest.java
Outdated
Show resolved
Hide resolved
This was referenced Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the following modules:
log4j-jakarta-smtplog4j-jakarta-weblog4j-jmslog4j-jpalog4j-smtplog4j-tagliblog4j-weband creates pointers to Log4j Jakarta wherever possible.
This PR contributes to the following tickets:
3.x#19513.x#1966Review aid
To ease the review process, I suggest the following approach:
main