Revamp database appenders #2790
Merged
+3,107
−1,148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppkarwasz
force-pushed
the
doc/2.x/appenders
branch
from
6fe75d0 to
eaae9e3
Compare
ppkarwasz
force-pushed
the
doc/2.x/appenders2
branch
from
b63146a to
70355f8
Compare
vy
requested changes
Aug 2, 2024
Member
vy
left a comment
vy
left a comment
There was a problem hiding this comment.
Great job @ppkarwasz! 💯 I can imagine you put great effort into checking each of these appenders in detail and trying out the shared configurations. 🤯
src/site/antora/modules/ROOT/pages/manual/appenders/database.adoc
Outdated
Show resolved
Hide resolved
src/site/antora/modules/ROOT/examples/manual/appenders/database/nosql-log-event.json
Show resolved
Hide resolved
src/site/antora/modules/ROOT/pages/manual/appenders/database.adoc
Outdated
Show resolved
Hide resolved
src/site/antora/modules/ROOT/pages/manual/appenders/database.adoc
Outdated
Show resolved
Hide resolved
src/site/antora/modules/ROOT/pages/manual/appenders/database.adoc
Outdated
Show resolved
Hide resolved
src/site/antora/modules/ROOT/pages/manual/appenders/database.adoc
Outdated
Show resolved
Hide resolved
src/site/antora/modules/ROOT/pages/manual/appenders/database.adoc
Outdated
Show resolved
Hide resolved
src/site/antora/modules/ROOT/pages/manual/appenders/database.adoc
Outdated
Show resolved
Hide resolved
vy
added
documentation
Contributor
Author
|
I refactored the example, to:
|
vy
approved these changes
Aug 2, 2024
This PR splits the documentation of database appenders into their own files. As in the previous PRs we: * check and reformat the configuration options, * add links to the Plugin Reference, * improve the readability of the description by shortening it and reformatting it,
ppkarwasz
force-pushed
the
doc/2.x/appenders2
branch
from
95bbbaa to
a884e99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the documentation of database appenders into their own files.
As in the previous PRs we:
Unlike other PRs, since these appenders are rarely used, we don't revamp their configuration examples.
Part of #2528.