Implement LocationAware for FileLocationPatternConverter (#2781)
#2795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedeibel
force-pushed
the
fix/file-location-pattern-converter-missing-location-requirement-2.x
branch
2 times, most recently
from
b71c33e to
98034af
Compare
dedeibel
force-pushed
the
fix/file-location-pattern-converter-missing-location-requirement-2.x
branch
from
98034af to
9f3c8d6
Compare
vy
reviewed
Aug 4, 2024
src/changelog/.2.x.x/2781_fix_file_location_pattern_converter_location_requirement.xml
Outdated
Show resolved
Hide resolved
vy
reviewed
Aug 4, 2024
...java/org/apache/logging/log4j/core/pattern/LocationPatternConvertersRequireLocationTest.java
Outdated
Show resolved
Hide resolved
vy
approved these changes
Aug 4, 2024
Member
vy
left a comment
vy
left a comment
There was a problem hiding this comment.
@dedeibel, good job! 💯
@ppkarwasz, I think this can be merged. Since you're the one who first reacted to the issue, I'd appreciate your conclusive review. If you're okay with it, please merge the PR.
Generated by gradle/develocity-actions |
vy
changed the title
LocationAware for FileLocationPatternConverter (#2781)
Member
Contributor
Author
vy
added
layouts
ppkarwasz
approved these changes
Aug 4, 2024
Contributor
ppkarwasz
left a comment
ppkarwasz
left a comment
There was a problem hiding this comment.
Looks good to me,
Thank you for you contribution.
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/package-info.java
Outdated
Show resolved
Hide resolved
vy
reviewed
Aug 6, 2024
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/package-info.java
Outdated
Show resolved
Hide resolved
Contributor
|
Closes #2781 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2781
See also #2782 (main branch)