LOG4J2-2882: Add support for JUL filters#381
Merged
rgoers merged 1 commit intoapache:masterfrom Jul 27, 2020
Merged
Conversation
Member
|
Now that I look at this I find what was originally implemented rather odd. The setLevel() and setParent() methods throw exceptions and yet the setFilter method is still allowed. It seems to me if setFilter is supported then setLevel should be too (i.e. it would call setLevel on the underlying Log4j Logger). But if setLevel isn't supported then I don't understand why setFilter would be. In any case, I wouldn't have setLevel throw an exception. At most I would just ignore the call. |
Member
Author
|
I agree that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements basic support for JUL filters as described in LOG4J2-2882. The log calls are delegated to the super class only when a filter is configured, I hope this preserves the performance in the general case. I left out the tracing methods because I wasn't sure delegating to the super class would generate a message with the right semantic.