Use binary names in GraalVmProcessor
#3996
Open
+32
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`GraalVmProcessor` currently emits canonical type names (JLS §6.7) for parameter types in the GraalVM reachability metadata. However, testing shows that GraalVM expects **binary names** (JLS §13.1) for reference types. For example: * Canonical: `org.apache.logging.log4j.core.Filter.Result` * Required (binary): `org.apache.logging.log4j.core.Filter$Result` For array types, GraalVM accepts two forms: * The JVM descriptor form: `[L<component_type>;` * The Java-like form: `<component_type>[]` This PR updates the processor to use binary names and emits the simpler Java-like syntax for arrays.
Contributor
Author
|
An integration test for this PR is contained in apache/logging-log4j-samples#385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraalVmProcessorcurrently emits canonical type names (JLS §6.7) for parameter types in the GraalVM reachability metadata. However, testing shows that GraalVM expects binary names (JLS §13.1) for reference types. For example:org.apache.logging.log4j.core.Filter.Resultorg.apache.logging.log4j.core.Filter$ResultFor array types, GraalVM accepts two forms:
[L<component_type>;<component_type>[]This PR updates the processor to use binary names and emits the simpler Java-like syntax for arrays.
Fixes #3871