Skip to content

Bump openjdk from 8 to 16#519

Closed
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/docker/openjdk-16
Closed

Bump openjdk from 8 to 16#519
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/docker/openjdk-16

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Jun 16, 2021

Bumps openjdk from 8 to 16.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps openjdk from 8 to 16.

---
updated-dependencies:
- dependency-name: openjdk
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Related to third party dependency updates or migrations docker Pull requests that update Docker code labels Jun 16, 2021
@vy
Copy link
Copy Markdown
Member

vy commented Jun 16, 2021

@chenrui333, can we fix this to OpenJDK 11?

@rgoers
Copy link
Copy Markdown
Member

rgoers commented Jun 16, 2021

I don't think it matters. As I said before you committed this, I don't believe we use the Dockerfile for anything. If we did this already wouldn't be working since we require Java 11 to run. There is a good chance I committed the file by accident when I was testing Spring Cloud Config support.

@vy
Copy link
Copy Markdown
Member

vy commented Jun 17, 2021

@rgoers, do you want me to convert this into a maven-docker-plugin execution as the one in log4j-layout-template-json? The benefit will be that one can start/stop containers using Maven at build or individually.

@chenrui333
Copy link
Copy Markdown

@chenrui333, can we fix this to OpenJDK 11?

yeah, we can totally pin the version in the dependabot for what version we preferred.

@chenrui333
Copy link
Copy Markdown

I don't think it matters. As I said before you committed this, I don't believe we use the Dockerfile for anything. If we did this already wouldn't be working since we require Java 11 to run. There is a good chance I committed the file by accident when I was testing Spring Cloud Config support.

It is just a one time thing. So for whatever dependency changes, it would show once for each dependency change.

@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot bot commented on behalf of github Sep 20, 2021

Superseded by #583.

@dependabot dependabot bot closed this Sep 20, 2021
@dependabot dependabot bot deleted the dependabot/docker/openjdk-16 branch September 20, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related to third party dependency updates or migrations docker Pull requests that update Docker code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants