Expand test suite for SortedArrayStringMap #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some corner cases of the equals and serialization methods of the SortedArrayStringMap class were not (unit) tested, and its hashCode method was not (unit) tested at all. This commit provides small changes to the test suite to address this.
avandeursen
changed the title
Member
|
These are great additions! Thanks so much @avandeursen! I will merge the changes as soon as build succeeds. |
vy
pushed a commit
that referenced
this pull request
Jan 9, 2022
…ion. (#688) Some corner cases of the equals and serialization methods of the SortedArrayStringMap class were not (unit) tested, and its hashCode method was not (unit) tested at all. This commit provides small changes to the test suite to address this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that some corner cases of the equals and serialization methods of the
SortedArrayStringMapclass were not (unit) tested, and that itshashCodemethod was not tested at all. This pull request provides small changes to the test suite to address this.Let me know if you have any questions, or if you would like a similar PR against the master (3.x) branch.
I also included a change earlier made in
masteron this file to bring the 2.x and 3.x versions more in sync.Thanks for your hard work on log4j.