Skip to content

Allow append to Apache Rat exclusions#85

Merged
vy merged 1 commit intomainfrom
apache-rat-exclusions-appends
Dec 22, 2023
Merged

Allow append to Apache Rat exclusions#85
vy merged 1 commit intomainfrom
apache-rat-exclusions-appends

Conversation

@grobmeier
Copy link
Member

This patch should allow to append additional exclusions from the child parent

This patch should allow to append additional exclusions from the child parent
@grobmeier grobmeier requested a review from vy December 21, 2023 17:47
@grobmeier
Copy link
Member Author

Usecase: Chainsaw contains *.log files for testing purposes, they cannot have a license. I am not sure if adding *.log is a good idea to the rat config, but maybe it is

@vy
Copy link
Member

vy commented Dec 22, 2023

@grobmeier, since this is only a Chainsaw-specific problem, why don't we only add a **/*.log exclude there? For instance, Log4j has several such RAT overrides.

@vy vy added the enhancement label Dec 22, 2023
@grobmeier
Copy link
Member Author

Because it didn't work yesterday - I might have done something wrong. After further clean up, the combine.children="append" property works as expected, so this PR with using combine.children="append" might not be necessary. I assume it could serve as a default though. but not necessary

@grobmeier
Copy link
Member Author

Btw, log4j2 also excludes log files:
https://github.com/apache/logging-log4j2/blob/2.x/pom.xml#L558

@vy
Copy link
Member

vy commented Dec 22, 2023

@grobmeier, I am not a big fan of "can be useful" ideas. If it helps with something, let's do it. Otherwise, let's wait until there is a use case. But that is me, and this is an innocent change. I leave it up to you. You can either merge or close the PR. Both are fine by me.

@grobmeier
Copy link
Member Author

The use case is that almost every use has specialties that needs to be appended, so it makes sense to me to define append in the parent and not in all childs. Is this use case strong enough for you.

@vy
Copy link
Member

vy commented Dec 22, 2023

Sounds good, merging.

@vy vy merged commit 41c16b6 into main Dec 22, 2023
@grobmeier grobmeier deleted the apache-rat-exclusions-appends branch December 23, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants