Extend CRLF non-finding to the Syslog layout and appender#31
Merged
Conversation
Reporters do not seem to realize that the Syslog layout (RFC 3164) handles CRLF characters the same way the RFC 5424 layout does, namely without treating them as special, nor that the Syslog appender can be configured with either layout. This broadens the FAQ section on CRLF injection from RFC 5424 alone to cover both layouts and clarifies that the same reasoning applies to the appender regardless of which one it uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reporters do not seem to realize that the Syslog layout (RFC 3164) handles CRLF characters the same way the RFC 5424 layout does, namely without treating them as special, nor that the Syslog appender can be configured with either layout. This broadens the FAQ section on CRLF injection from RFC 5424 alone to cover both layouts and clarifies that the same reasoning applies to the appender regardless of which one it uses.