SOLR-12477 - Return server error(500) for AlreadyClosedException instead of client Errors(400) #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferyyuan
force-pushed
the
master
branch
4 times, most recently
from
7fe62cf to
4503a1f
Compare
jefferyyuan
force-pushed
the
master
branch
4 times, most recently
from
7723714 to
93a4c26
Compare
vthacker
reviewed
Jul 28, 2018
| } | ||
| } | ||
| } catch (Exception e) { | ||
| boolean hasTragicException = false; |
Contributor
There was a problem hiding this comment.
Here is what I was thinking of after this statement. What do you think?
if (isTragic) {
if (e instanceof SolrException) {
assert ((SolrException) e).code() == 500; //Tragic exceptions should always throw a server error
} else {
//wrap it in a solr exception
e = new SolrException(SolrException.ErrorCode.SERVER_ERROR, e);
}
}
Contributor
There was a problem hiding this comment.
Looking at LeaderTragicEventTest.java maybe we should check if the code is a 500 or a 404 also?
Author
There was a problem hiding this comment.
@vthacker
Changed the code as you suggested, and like you variable name: isTragic :)
I verified the error code of RemoteSolrException is one of 500 or 404 in LeaderTragicEventTest.java for update or commit:
assertThat(se.code(), anyOf(is(500), is(404)));
jefferyyuan
force-pushed
the
master
branch
3 times, most recently
from
1c37d7a to
bcf8931
Compare
…ead of client Errors(400)
asfgit
pushed a commit
that referenced
this pull request
Jul 31, 2018
…ad of client Errors(400) . This closes PR #402
Author
|
Close this as @vthacker has submitted this in https://issues.apache.org/jira/browse/SOLR-12477 :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-12477
In some cases(for example: corrupt index), addDoc0 throws AlreadyClosedException, but solr server returns client error 400 to client
This will confuse customers and especially monitoring tool.