-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closed
Description
This causes the generation to always make changes to the file, even if the list of TLDs has changed. Let's avoid this as generating the resultant tokenizer is not trivial :)
Also if we fix this, it allows us to run ./gradlew regenerate --rerun-tasks and have no local changes (idempotency everywhere)
Diffs currently look like this:
--- a/lucene/analysis/common/src/java/org/apache/lucene/analysis/email/ASCIITLD.jflex
+++ b/lucene/analysis/common/src/java/org/apache/lucene/analysis/email/ASCIITLD.jflex
`@@` -16,7 +16,7 `@@`
*/
// Generated from IANA Root Zone Database <https://www.internic.net/zones/root.zone>
// file version from 2021 Apr 10, Sat 17:37:00 Coordinated Universal Time
-// generated on 2021 Apr 10, Sat 17:55:26 Coordinated Universal Time
+// generated on 2021 Apr 10, Sat 18:13:07 Coordinated Universal Time
// by org.apache.lucene.analysis.standard.GenerateJflexTLDMacros
// #9325: None of the TLDs in {ASCIITLD} is a 1-character-shorter prefix of another TLD
Migrated from LUCENE-9923 by Robert Muir (@rmuir), resolved Apr 10 2021
Pull requests: #76