LUCENE-9923: remove always-changing timestamp from ASCIITLD.jflex generation #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way the files don't unnecessarily change, depending on filesystem order or anything else.
…eration This makes regenerate idempotent by removing the new Date() from the output. We already have the root.zone's Last-Modified date, which is the one that matters and only changes when the root.zone changes.
janhoy
pushed a commit
to cominvent/lucene
that referenced
this pull request
May 12, 2021
This commit introduces the concept of task management in Solr. Tasks can be marked as cancellable (thus, trackable) and can then be listed (ps -all), cancelled and specific task's status be queried. This commit also implements SOLR-15165. Please refer to the JIRA for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time you regenerate, it results in changes:
Remove the
new Date()that causes this to happen. We already write the "good" date, that's theLast-Modifieddate of the root.zone input file.