Rename Analyzer.reusableTokenStream() to tokenStream() [LUCENE-3466]

[asfimport]

All Analysis consumers now use reusableTokenStream(). To finally make reuse mandatory, lets rename resuableTokenStream() to tokenStream() (removing the old tokenStream() method).

---

Migrated from LUCENE-3466 by Chris Male, resolved Sep 28 2011
Parent: #4469
Attachments: LUCENE-3466.patch (versions: 2)

[asfimport]

Chris Male (migrated from JIRA)

Patch which does what is described above.

Everything passes. Yay!

[asfimport]

Simon Willnauer (@s1monw) (migrated from JIRA)

awesome! This is the end of reusableTokenStream! If I remember correctly this work has started in late 2009 and now it seems it only one commit away! Thanks chris!

[asfimport]

Robert Muir (@rmuir) (migrated from JIRA)

+1, though i have a few additional suggestions:

• TokenStream.reset() is described by the docs as optional, i think we should adjust the docs here.
• We might be able to re-word some of the stuff in Analyzer javadocs about inconsistencies (Since these are gone!)

[asfimport]

Chris Male (migrated from JIRA)

New patch which improves documentation on TokenStream.reset() and Analyzer.

[asfimport]

Robert Muir (@rmuir) (migrated from JIRA)

+1 to commit

[asfimport]

Chris Male (migrated from JIRA)

Committed revision 1176728.