disable manual invocation of internal untested ant targets [LUCENE-4416]

[asfimport]

This typically comes up at e.g. release vote time, people try to run one of the many targets that happens to have a "description" in build.xml, but is really internal.

e.g. if someone runs 'dist-contrib Make the contribs ready for distribution' from solr, will it work? I have no idea. probably not.

we should change some of these to be e.g. -dist-contrib or whatever, so there are no complaints.

---

Migrated from LUCENE-4416 by Robert Muir (@rmuir)

[asfimport]

Chris M. Hostetter (@hossman) (migrated from JIRA)

why don't we just remove the descriptions (ie: move them into xml comments) so they don't show up in "ant -p" at all?

[asfimport]

Robert Muir (@rmuir) (migrated from JIRA)

I think we should both remove the descriptions and hyphenate them,
this way they are impossible to execute standalone, the only targets
that are shown in ant -p, and the only targets you can run at all are the
ones we test.

This relieves the onus from being on the release manager to manually test this
kind of stuff before releases.

[asfimport]

Chris M. Hostetter (@hossman) (migrated from JIRA)

this way they are impossible to execute standalone,

Ah ... ok, right: you can't specify them on the command line because they start with a hyphen.

+1

[asfimport]

Robert Muir (@rmuir) (migrated from JIRA)

...and all said targets we want to support should be tested from a totally
clean checkout (ant clean clean-jars), so we know that both their
dependencies are correct, and they resolve anything they need.

for example, today we don't really "test" javadocs, because it runs
after 'ant test' is done.

"ant javadocs" could be and has been in the past broken standalone, where
it doesnt properly resolve e.g. 3rd party libraries but happens to work if
its run after other things which forced lib/ to be populated.

So today this is an example of what I mean by unsupported target.

if a user sent an email tonight to the list saying "can't build javadocs for 4.0,
the ant target fails", because it didnt resolve its dependencies correctly if
you weren't previously doing other shit, i wouldn't be surprised at all. And
then we would have blocker issues/ respins / etc etc when we can avoid this with
just some jenkins testing.

[asfimport]

Robert Muir (@rmuir) (migrated from JIRA)

The best way to implement these checks imo is to add the
appropriate 'clean clean-jars' to the smokeTester.py in between the things it tests.