nightly-smoke should run some fail fast checks before doing the full smoke tester [LUCENE-5093]

[asfimport]

If something like the NOTICES fail the smoke tester, it currently takes 22 minutes to find out on my pretty fast machine. That means testing a fix also takes 22 minutes.

It would be nice if some of these types of checks happened right away on the src tree - we should also check the actual artifacts with the same check later - but also have this fail fast path.

---

Migrated from LUCENE-5093 by Mark Miller (@markrmiller), updated May 09 2016
Attachments: LUCENE-5093.patch

[asfimport]

Mark Miller (@markrmiller) (migrated from JIRA)

Don't laugh, I don't know python at all.

This adds one fail fast check for the testNotice check.

[asfimport]

Robert Muir (@rmuir) (migrated from JIRA)

awesome! i think a lot of these checks do run on the source tree thats in the release .tar.gz.

so if we can do what you did here, and make a lot of the fast ones accessible directly on the source tree, we could incorporate these kinda things even into every jenkins build (via precommit: rather than just the heavy-duty check that takes 30 minutes and runs once a day or something).

and it makes fixing things locally faster.

[asfimport]

Uwe Schindler (@uschindler) (migrated from JIRA)

I would prefer to have these checks in plain Ant or Ant-embedded Groovy logic. No need for python here... I can help with implementing those.

[asfimport]

Robert Muir (@rmuir) (migrated from JIRA)

another check we could add in the future like this: the smokeTester checks some things about changes.html.

I've had to respin (30 minutes to see the fail, then fix, then 30 more minutes to make sure it passes) because of a leftout or extra ":" character in CHANGES.txt before. Really it would be nice if the documentation-lint that runs as part of precommit found that earlier...

[asfimport]

Mark Miller (@markrmiller) (migrated from JIRA)

I would prefer to have these checks in plain Ant or Ant-embedded Groovy logic.

I think it depends - unless we rewrite the whole smoke tester, I think it's better that this logic is in one place - the smoke tester script. Otherwise, over time, some checks might be added to the testNotice method of the smoke tester but not to the fast fail check in ant or groovy, and then it doesn't help much with fixing smoke tester fails. Any expansion of tests will have to be done in two places, in two non java languages (yuck and yuck).

[asfimport]

Steven Rowe (@sarowe) (migrated from JIRA)

Bulk move 4.4 issues to 4.5 and 5.0

[asfimport]

Uwe Schindler (@uschindler) (migrated from JIRA)

Move issue to Lucene 4.9.