Skip to content

AnalyzingSuggester needs reasonable limits on max suggestion length [LUCENE-5660] #6722

@asfimport

Description

@asfimport

Issues like #6690 LUCENE-5659 are hacks around the problem that the AnalyzingSuggester allows automata to "explode".

I don't think we should try to hack up the automata lib to the point its un-understandable to support this, since its designed for smaller automata such as queries and is appropriate for that.

We should instead just set appropriate limits out of box so AnalyzingSuggester doesnt blow up.

Remember this is a suggester, it needs to be fast. The fact that the automata lib blows up on stupid unit tests or whatever are doing this, instead of being silently slow, is a good thing.


Migrated from LUCENE-5660 by Robert Muir (@rmuir)
Attachments: LUCENE-5660.patch

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions